Increase mouse-wheel vertical scrolling speed in ScrollPane #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android-X13
force-pushed
the
speed-up-scrolling
branch
from
bb33833
to
620d459
Compare
|
Signed the commit |
|
Is that tested with all OS? On OSX I don't have any issues with scroll speed and it works with accelleration. In doubt apply it only to the OS where you obsereved issues. |
|
It's tested on Windows and Debian (with GNOME), not on MacOS. I can exclude MacOS and maybe even Linux (although in Debian it's an issue - the motion you see in the "Before" video, which was recorded on Windows, is the same in that distro). |
ghost
previously approved these changes
Nov 29, 2022
|
I'll probably need to add an OS check to exclude MacOS then, unless someone can test it there as well |
|
Better exclude it on OSX as there is no problem with it. |
Signed-off-by: Android-X13 <76814540+Android-X13@users.noreply.github.com>
Android-X13
force-pushed
the
speed-up-scrolling
branch
from
620d459
to
53c0f0b
Compare
|
OSX and everything else: excluded |
ghost
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3017
This PR increases the mouse-wheel scrolling "speed" inside scrollpanes (as stated in the linked issue above the scrolling is slow only inside ScrollPane but not in other components like TableView). I believe that the speed now is more or less of the degree that is usually expected universally in any kind of application.
Apparently the scroll amount in a ScrollPane depends on the content's full height, so the speed usually differs between views. If the content's height is large enough then the scrolling speed will be faster, but if the content is only slightly larger than the viewable area then the scrolling speed is slower. Example: NetworkSettingsView, where the scrolling speed is painfully slow when the window is maximized. The technique used here makes it so the speed is almost (but not exactly) equal in all scrollable views.
Initally I made this to apply only on Windows machines but after testing on a Debian GNOME system there doesn't seem to be any difference, so I removed the OS check. I have not tested this on MacOS.
I'm using a custom
BisqScrollPanecomponent here, an alternative way would be to use helper methods like setFasterScrollSpeed in GUIUtil. I've tested that code too so I can switch to that approach if requested.Before:
Before.mp4
After:
After.mp4