Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java to v11 and JavaFX to v15 #5431

Merged
merged 86 commits into from
Apr 22, 2021

Commits on Sep 16, 2020

  1. Upgrade JavaFX to v14

    Update the gradle dependency to JavaFX 14.
    
    This brings to Bisq the latest JavaFX fixes and improvements, especially
     in the areas of UI performance, memory management and security.
    
    JavaFX can be upgraded independently of the JDK used to build the
    application, so this change is modular and does not affect other parts
    of the build process.
    
    Related / likely related to: bisq-network#350 bisq-network#2135 bisq-network#2509 bisq-network#3128 bisq-network#3307 bisq-network#3308 bisq-network#3343
    bisq-network#3430 bisq-network#3657 bisq-network#3677 bisq-network#3683 bisq-network#3686 bisq-network#3786 bisq-network#3787 bisq-network#3892 bisq-network#3917 bisq-network#3918 bisq-network#3936
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2ce807c View commit details
    Browse the repository at this point in the history
  2. Upgrade buildserver config to OpenJDK 14

    Use java 14 to build the necessary artifacts. This is the most recent
    version which brings support for JavaFX 14, as well as a newer packager
    tool to build native applications.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    1109baf View commit details
    Browse the repository at this point in the history
  3. Upgrade to Gradle 6.3

    Use Gradle 6.3, which adds support for Java 14.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    77134a9 View commit details
    Browse the repository at this point in the history
  4. Upgrade to Lombok 1.18.12

    Use Lombok v1.18.12, which adds support for Java 14.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    e6920c1 View commit details
    Browse the repository at this point in the history
  5. Upgrade to Mockito 3.3.0

    Use Mockito 3.3.0, which fixes some bugs that caused valid tests to fail
    in the Java 14 environment.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    2bc85d7 View commit details
    Browse the repository at this point in the history
  6. Fix UnnecessaryStubbingException in test

    Remove duplicate call to a stubbed method. This caused an
    UnnecessaryStubbingException with Mockito's strict validation settings.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    7a73fea View commit details
    Browse the repository at this point in the history
  7. Fix FeeReceiverSelectorTest

    Split test into sub-tests in order to avoid mockito UnnecessaryStubbingExceptions. These exceptions occurred because of 3 ambiguous uses of "when().thenReturn()" in the same test. These calls were ambiguous, because the when() argument was identical and mockito did not check the thenReturn() arguments, which would have differentiated the calls. Splitting this test method into 4 test methods achieved this call differentiation.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    e55594d View commit details
    Browse the repository at this point in the history
  8. Upgrade JavaFX to v15

    Upgrade JavaFX to most recent release.
    cd2357 committed Sep 16, 2020
    1 Configuration menu
    Copy the full SHA
    51e0de8 View commit details
    Browse the repository at this point in the history
  9. Upgraded Gradle to v6.6.1

    Upgraded Gradle to the latest version, which has better module-info support for the imported gradle dependencies.
    cd2357 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    dc9288c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Codacy: Fix md styling

    Fix styling to match Codacy rules.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    f8dfcc9 View commit details
    Browse the repository at this point in the history
  2. Codacy: Fix md styling, part 2

    Fix styling to match Codacy rules.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    9cc7785 View commit details
    Browse the repository at this point in the history
  3. Codacy: Fix md styling, part 3

    Fix styling to match Codacy rules.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    24296fa View commit details
    Browse the repository at this point in the history
  4. Codacy: Fix md styling, part 4

    Fix styling to match Codacy rules.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    b877c9f View commit details
    Browse the repository at this point in the history
  5. Codacy: Fix md styling, part 5

    Fix styling to match Codacy rules.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c82d76e View commit details
    Browse the repository at this point in the history
  6. Upgrade apache-commons-lang3 to v11 to avoid jdeps issue

    Updated the commons-lang3 version to the latest one, to avoid the existence of multiple versions used by different projects.
    
    Before, v3.8 was used in most projects and v3.9 was brought as a transitive dependency in pricenode. So both were used by different projects. With this commit, all projects use v3.11, since it is explicitly defined in build.gradle.
    
    This resolves an exception thrown by jdeps when trying to list the module dependencies of the desktop-vXYZ-SNAPSHOT-all.jar.
    cd2357 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    4322e72 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Codacy: Fix md styling, part 5

    Fix styling to match Codacy rules.
    cd2357 committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    aae9970 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fbe43c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Codacy: Test tag to skip check

    Try out optional tag to check how it affects codacy behavior. [skip ci]
    cd2357 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    ef680f9 View commit details
    Browse the repository at this point in the history
  2. Include version in bisq-desktop jar manifest

    Include the application version number in the jar manifest. This makes it easier later on, in the packaging process, to programmatically retrieve the build version from a reliable source.
    cd2357 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    b9164e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Integrate jpackage to build platform-specific binaries

    Extend the gradle script with tasks that use jpackage to generate Bisq binaries. The kind of binaries generated depend on the OS where this is executed.
    
    The packaging of binaries can be started by calling:
    ./gradlew --console=plain packageInstallers
    from the root project folder.
    cd2357 committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    150599c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Update jfoenix to latest v9.0.10

    Update jfoenix to attempt to fix JavaFX NPEs.
    cd2357 committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    50f5d9b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Fix JDK v15 installer download URL

    Fix the logic used to determine the JDK 15 assets and download links. Pre-releases are now excluded, as well as openj9 binaries. The resulting assets are final releases of hotspot builds.
    cd2357 committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    d8d3371 View commit details
    Browse the repository at this point in the history
  2. Add support for jdk11 runtime-image

    Update jpackage arguments such that a specific java version is packaged in the installers (in this case, v11).
    cd2357 committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    ce5d4ee View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Remove translation to prevent clipping after jFoenix update

    The drawback of this is that the floating label on top of the
    Field is not properly left aligned anymore.
    A proper fix would mean more re-writing of the jFoenix library
    which would make it harder and harder to maintain for applying
    library updates.
    ripcurlx committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    8137cb9 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. macOS binaries: remove pkg

    Update build script to only build the dmg for macOS.
    cd2357 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    91190ee View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Fix jpackage option concatenation

    Fixed typo affecting jpackage option concatenation, where a missing "+" caused subsequent options to not be considered. Surround concatenated options with parentheses, to ensure such a typo in the future is marked as a syntax error, and therefore avoided.
    cd2357 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    ebadce5 View commit details
    Browse the repository at this point in the history
  2. Remove jpackage Windows TODO

    Remove TODO, since previous argument concatenation fix addressed the issue (desktop and start menu shortcuts are created now).
    cd2357 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    45a27af View commit details
    Browse the repository at this point in the history
  3. Fix macOS dmg background image

    Update macOS setup script to use the tiff image in the installer bundle, as this is the type of background image expected and included by jpackage.
    
    Convert Bisq-background.png to Bisq-background.tiff using imagemagick.
    cd2357 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    e409b49 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Set -Djdk.module.illegalAccess=deny

    Backport bisq-network#4600 into this PR.
    
    Set `-Djdk.module.illegalAccess=deny` in order to reduce warning in startup logs.
    cd2357 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0b40dff View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Disable '-Djdk.module.illegalAccess=deny' javaoption

    Disable the java option because it causes issues in the resulting app if packaged with a recent Java Runtime (tested with Java 11, 14 and 15).
    cd2357 committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    696a788 View commit details
    Browse the repository at this point in the history
  2. Remove --runtime-image option using separate JDK

    Remove the --runtime-image jpackage option, which was packaging Java 11 in the resulting installers. Reason is that jpackage 15 does not properly package the Java 11 runtime, but contains necessary features for signing and notarizing the app. On the other hand, jpackage 14 does package the Java 11 runtime correctly in the resulting installers, but does not support proper signing and notarizing.
    cd2357 committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0a1b581 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Configuration menu
    Copy the full SHA
    a92c392 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Configuration menu
    Copy the full SHA
    416373e View commit details
    Browse the repository at this point in the history
  2. Bump mockito version to fix tests

    Newer mockito version fixes tests which started failing for this branch after the merge of v1.4.2.
    cd2357 committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    0cd97a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Configuration menu
    Copy the full SHA
    72a719d View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Fix issue when building deb and rpm at the same time

    Fixed an issue in the Linux section, which didn't allow building both rpm and deb packages at the same time.
    cd2357 committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    5b80b6d View commit details
    Browse the repository at this point in the history
  2. Windows: Remove msi package

    For Windows, generate only the exe installer.
    cd2357 committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    9859750 View commit details
    Browse the repository at this point in the history
  3. Linux: Improve package names

    The generated package names include, by convention, two version numbers: the app version and the package version. The first one is set to the Bisq software version, the second is now set to 1.
    
    The resulting package names are:
    - bisq_1.5.0-1_amd64.deb
    - bisq-1.5.0-1.x86_64.rpm
    cd2357 committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    8f9cede View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Add checksum verification for downloaded JDK binaries

    Verify downloaded JDK binary hash against list of known (expected) hash values for the different JDK versions and OS platforms.
    cd2357 committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    e0a37e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. Configuration menu
    Copy the full SHA
    b82f3c1 View commit details
    Browse the repository at this point in the history
  2. Make temp folder name more readable

    Change packaging temp folder name from a random string to a timestamp.
    cd2357 committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    9d20d2b View commit details
    Browse the repository at this point in the history
  3. macOS: Add optional step to sign dylibs

    Extend macOS packaging process with optional y/n step where relevant dylibs are extracted, signed, and re-added back to the shadow jar, before packaging it into the final app.
    cd2357 committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    88cd0e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. macOS: Read signing identity from environment variable

    Read the macOS signing identity from the user's environment variable.
    cd2357 committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    323fcc3 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. macOS: Sign app-image and bundle when packaging

    Update the macOS packaging process with the ncessary steps to sign the app-image and the final dmg package.
    cd2357 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c8d0a7f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. macOS: Include entitlements plist

    Add the entitlements mapping file needed for the signing process.
    cd2357 committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    8d74a1b View commit details
    Browse the repository at this point in the history
  2. macOS: Include entitlements plist, part 2

    Include the full path to the entitlements mapping file in all codesign calls.
    cd2357 committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    33297c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Configuration menu
    Copy the full SHA
    02f5988 View commit details
    Browse the repository at this point in the history
  2. macOS: Fix command string concatenation

    Add missing space before final argument in a multi-line command string.
    cd2357 committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    b272caf View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. macOS: Add notarization step

    Add step for uploading the packaged dmg to the notarization service. Add a second step for monitoring the progress of notarization.
    cd2357 committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    7285b98 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Remove unnecessary colons

    ripcurlx committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    e80213f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71e6e53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    808749d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Configuration menu
    Copy the full SHA
    8416f56 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    a10b63e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47c4e09 View commit details
    Browse the repository at this point in the history
  3. Sign Windows installer

    Add signing step in the Windows installer generation.
    cd2357 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    04737f4 View commit details
    Browse the repository at this point in the history
  4. Fix typos

    Fix several typos and updated a comment.
    cd2357 committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    85af986 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Configuration menu
    Copy the full SHA
    d09a4ec View commit details
    Browse the repository at this point in the history
  2. Remove license confirmation prompt

    As we already have a TAC popup in place on first application launch
    ripcurlx committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    8b5c6d8 View commit details
    Browse the repository at this point in the history
  3. Extract re-used arguments

    ripcurlx committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    74efd53 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    48ef145 View commit details
    Browse the repository at this point in the history
  5. Replace non-existing contact email

    To make it clear that there will be no response when using it
    ripcurlx committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    7cf7410 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Update travis config to Java 11

    Update the JDK used by Travis to JDK 11.
    cd2357 committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    2277b6e View commit details
    Browse the repository at this point in the history
  2. Create deterministic jar

    Convert the fat jar into a deterministic one before it is packaged in the generated installers.
    cd2357 committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c03ff3c View commit details
    Browse the repository at this point in the history
  3. Save deterministic jar hash

    Store the SHA-256 of the deterministic jar next to the generated binaries.
    cd2357 committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    b7188ec View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Change windows binary permissions before signing

    Explicitly set the permissions on the generated exe binary, which are required by the signtool.
    cd2357 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    b231c96 View commit details
    Browse the repository at this point in the history
  2. Surround windows command in quotes

    Surround entire command in quotes, to avoid issues with cmd parsing for a command with custom flags and space-containing arguments (full path of the exe arg).
    cd2357 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    1808feb View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Cleanup Windows comments

    Remove superfluous comments about the Windows setup.
    cd2357 committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1a546b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a358b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    7c2b4e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Merge remote-tracking branch 'bisq-network/hotfix/v1.6.1' into upgrad…

    …e-javafax-14
    
    # Conflicts:
    #	build.gradle
    cd2357 committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    ca5f41a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Configuration menu
    Copy the full SHA
    e04537a View commit details
    Browse the repository at this point in the history
  2. Add jar lib for Raspberry Pi

    Include a zip with the relevant libs for running on raspi. Place the zip in the generated binaries folder.
    cd2357 committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    9705374 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Customize Windows installer

    ripcurlx committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    7e6ab7b View commit details
    Browse the repository at this point in the history
  2. Revert temp. disabling of rasperry-pi zip generation

    Needs to be either only executed on macOS or adapted to work with Windows as well
    ripcurlx committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f862fc2 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Temporary delete QR code scanner

    used for mobile notification pairing because of missing current macOS support by currently used webcam library
    ripcurlx committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b5beea5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3281767 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41fa3a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Remove old build files

    ripcurlx committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    2463e28 View commit details
    Browse the repository at this point in the history
  2. Update Java SDK

    ripcurlx committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    5dc8abd View commit details
    Browse the repository at this point in the history
  3. clean up formatting

    ripcurlx committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    bbe6c70 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8957685 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Autoformat markdown file

    ripcurlx committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1ae8fc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f44ffb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42e049c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    412d485 View commit details
    Browse the repository at this point in the history