Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon eGift Card payment method #4788

Merged

Conversation

chimp1984
Copy link
Contributor

Implements: #1866

@ripcurlx Would be cool if we could get it in 1.5.0. I think its not very risky and might be a interesting payment option.

@m52go Could you have a look at the popup text?

portfolio.pending.step2_buyer.amazonGiftCard=Please purchase an Amazon eGift Card for {0} at your Amazon account and \
  use the BTC seller''s email or mobile number as receiver. \
  In case the trade amount exceeds the permitted amount send multiple cards.\n\n

portfolio.pending.step3_seller.amazonGiftCard=The buyer has sent you an Amazon eGift Card by email or by text \
  message to your mobile phone. Please redeem now the Amazon eGift Card at your Amazon account and once accepted \
  confirm the payment receipt.
  
payment.amazonGiftCard.info=To pay with Amazon eGift Card you need to purchase an Amazon eGift Card at your Amazon account and \
  use the BTC seller''s email or mobile nr. as receiver. Amazon send then an email or text message to the receiver. \
  Use the trade ID for the message field.\n\n\
  Amazon eGift Cards can only be redeemed by Amazon accounts with the same currency.\n\n\
  For more information visit the Amazon eGift Card webpage. [HYPERLINK:https://www.amazon.com/Amazon-1_US_Email-eGift-Card/dp/B004LLIKVU]

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Code looks fine - I'll do a test trade during release testing.

@ripcurlx ripcurlx merged commit 4eb43d7 into bisq-network:release/v1.5.0 Nov 13, 2020
@m52go
Copy link
Contributor

m52go commented Nov 13, 2020

Text looks ok.

@chimp1984 chimp1984 deleted the add-amazon-gift-cards branch November 13, 2020 21:43
@ripcurlx ripcurlx added this to the v1.5.0 milestone Nov 19, 2020
@ripcurlx
Copy link
Contributor

Text looks ok.

Bildschirmfoto 2020-11-20 um 15 19 28

Shouldn't it be "Amazon sends"?

@chimp1984
Copy link
Contributor Author

Text looks ok.

Bildschirmfoto 2020-11-20 um 15 19 28

Shouldn't it be "Amazon sends"?

Yes.

@chimp1984
Copy link
Contributor Author

Fixed in #4827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants