Fix historical data store issue #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we might have same keys in multiple maps and merge those to 1 map we cannot use an immutable map when merging the maps. Instead we copy our merged map at the end into a immutable map. Fix issue with immutable maps. As we might have same keys in multiple maps and merge those to 1 map we cannot use an immutable map when merging the maps. Instead we copy our merged map at the end into a immutable map.
It should be only needed in case we get the historical data from resources, but as I have seen multiple times that some nodes have duplicated entries in the live data I think its more safe to clean up always. If no entries are removed the call is very cheap. Even with 60k entries to be pruned it takes only about 20 ms.
ripcurlx
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we might have same keys in multiple maps and merge those to 1 map we
cannot use an immutable map when merging the maps. Instead we copy our merged map
at the end into a immutable map.
Also prune live data always instead of just when we apply historical data from resource files.