Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to 'Edit Offer' to allow for change of market and payment method #4728

Merged
merged 1 commit into from Oct 31, 2020
Merged

Updates to 'Edit Offer' to allow for change of market and payment method #4728

merged 1 commit into from Oct 31, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2020

Display the trading account group on edit offer screen which allows the market and payment method to be chosen.

When applying the edits to the new offer payload, merge in appropriate fields that describe the market & payment method:

  • base and counter currency codes
  • payment method and account
  • country code, accepted country codes
  • bankid and accepted bankIds

Fixes #4720

Display the trading account group on edit offer screen which allows
the market and payment method to be chosen.

When applying the edits to the new offer payload, merge in appropriate
fields that describe the market & payment method:
- base and counter currency codes
- payment method and account
- country code, accepted country codes
- bankid and accepted bankIds

Fixes #4720
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Did basic test on regtest and seems all works ok. Still would need more testing but great that you implemented that so fast and with such little code changes!

@sqrrm sqrrm merged commit b3a95ab into bisq-network:master Oct 31, 2020
@ripcurlx ripcurlx added this to the v1.5.0 milestone Nov 3, 2020
@ghost ghost mentioned this pull request Nov 26, 2020
@ghost ghost deleted the edit_offer_change_market branch May 29, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to 'Edit Offer' to allow for change of market and payment method
3 participants