Show if maker has xmr autoconf enabled #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If maker is seller and is a xmr offer and has autoConf enabled we set a flag ("1")
Add info to tooltip and to offer window Add center css to actions column. It looks weird that title is left aligned and button is centered. only "last-column", "avatar-column" worked, making an new style e.g. center-column did not succeed... css is not my friend.... Shorten "Time since signing" to "Signed since" header to avoid truncation
ripcurlx
reviewed
Sep 30, 2020
| @@ -338,7 +338,7 @@ offerbook.offerersAcceptedBankSeats=Accepted seat of bank countries (taker):\n { | |||
| offerbook.availableOffers=Available offers | |||
| offerbook.filterByCurrency=Filter by currency | |||
| offerbook.filterByPaymentMethod=Filter by payment method | |||
| offerbook.timeSinceSigning=Time since signing | |||
| offerbook.timeSinceSigning=Signed since | |||
There was a problem hiding this comment.
Did you change this to save space?
|
@chimp1984 How about using the fast clock instead of the rocket? |
|
Yes ok as well, though i felt the rocket might add more incentive is looks a bit more "special"... but feel free to use the clock, no strong opinion here... |
|
Maybe the clock could be used for all instant trade options? |
|
Expressing my preference for the rocket! I think it looks cool and may generate interest in the feature...
|
|
Yes I think it sticks out a bit more than a more traditional icon. The "to the moon" crew will like it as well ;-) |
ok - voted down and I accept my defeat 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4569