Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with missing remove of old filter when new filter is added. #4576

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

chimp1984
Copy link
Contributor

Fix bug with missing remove of old filter when new filter is added.

Add handling for removing invalid filters
When adding a new filter invalid filters get removed if they have been created with the same priv key.

- Add handling for removing invalid filters

When adding a new filter invalid filters get removed if they have been created with the same priv key.
@ripcurlx ripcurlx added this to the v1.4.0 milestone Sep 30, 2020
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Code is looking fine and testing it on Mainnet where I experienced this issue solved my problem.

@ripcurlx ripcurlx merged commit 4d7e26d into bisq-network:master Sep 30, 2020
@chimp1984 chimp1984 deleted the fix-filter-bug branch September 30, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants