Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature to dispute result and various other improvements #4543

Merged
merged 42 commits into from
Sep 25, 2020
Merged

Add signature to dispute result and various other improvements #4543

merged 42 commits into from
Sep 25, 2020

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Sep 21, 2020 •
edited
Loading

Depends on #4542

Add various new features to dispute domain.

  • Add signature to summary message and validation popup so the signature and the msg can be validated
  • Allows refund agent to close cases without a payout
  • Adds validation for node addresses, deposit and payout txs and donation address
  • Add copy as csv button at report screen for dispute agents
  • Improves search field and shows tooltip if match is found from which source the match was made (e.g. deposit Tx, json,..)

@chimp1984
Add check for refund agent if donation address is valid
4f1cbbd
@chimp1984
Dont allow opening refudn agent dispute if delayed payout tx is invalid.
2b04338
@chimp1984
Improve address validation code
c48abbf
@chimp1984
Fix some issues found during testing
d82631f 
Refactorings
@chimp1984
Allow close dispute for refund agent without payout
677211b
@chimp1984
Call validatePayoutTx only after trades are initialized
08fb596
@chimp1984
Call validatePayoutTx only after trades are initialized
05e1039
@chimp1984
Dispute agent sign summary. Add tool for verification
7ac6e71
@chimp1984
Remove unused var
559028e
@chimp1984
Remove setting of pubKey as it is not needed
48066ae
@chimp1984
Add more data to summary msg
0c46e7d
@chimp1984
Improve summary notes
de4fb17
@chimp1984
Fix line breaks
966b22a
@chimp1984
Merge branch 'master_upstream' into allow-refund-agent-close-without-…
29f3a7c 
…payout
@chimp1984
Merge branch 'master_upstream' into dispute-agents-sign-summary
b0b4334
@chimp1984
Merge branch 'master_upstream' into verify-donation-address-for-refun…
1c0bef7 
…d-agent
@chimp1984
Fix wrong handling of mainnet RECIPIENT_BTC_ADDRESSes
1c41db4 
We must not add main net addresses if not on mainnet
@chimp1984
Add result of filter match. Add more filter data (tx ids, json)
3d4427c
@chimp1984
Add check for disputes with duplicated trade ID or payout tx ids
45cee2a
@chimp1984
Merge branch 'dispute-agents-sign-summary' into dispute-agent-branch
f46a991
@chimp1984
Merge branch 'verify-donation-address-for-refund-agent' into dispute-…
b2a9262 
…agent-branch

# Conflicts:
#	core/src/main/java/bisq/core/support/dispute/DisputeManager.java
#	desktop/src/main/java/bisq/desktop/main/support/dispute/agent/DisputeAgentView.java
@chimp1984
Merge branch 'master_upstream' into dispute-agent-branch
c1850cb 
# Conflicts:
#	desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java
@chimp1984
Set agentsUid to new uuid in case it is null from persisted data
3293047
@chimp1984
Remove dev log
d31deff
@chimp1984
Add check for multiple deposit txs
25bc616
@chimp1984
Optimize testIfDisputeTriesReplay methods to avoid that maps get crea…
4878a10 
…ted at each iteration
@chimp1984
Add copy to csv data button to report screen
c6778d6
@chimp1984
Add cylce index
72dca0b
@chimp1984
Remove agentsUid from protobuf, rename to uid
2943316
@chimp1984
Refactor: rename DelayedPayoutTxValidation to TradeDataValidation
30e9add
@chimp1984
Refactor: Move RegexValidator from bisq.desktop.util.validation to bi…
3206c62 
…sq.core.util.validation

Add RegexValidatorFactory
Move regex tests from GUIUtilTest to new RegexValidatorTest class
@chimp1984
Add node address validation
987bf49
@chimp1984
Add validateNodeAddress at onOpenNewDisputeMessage
baa915f 
- Cleanups
@chimp1984 chimp1984 changed the title Dispute agent branch Dispute domain improvements Sep 21, 2020
@chimp1984 chimp1984 changed the title Dispute domain improvements Add signature to dispute result and various more improvements Sep 21, 2020
@chimp1984 chimp1984 changed the title Add signature to dispute result and various more improvements Add signature to dispute result and various other improvements Sep 21, 2020
sqrrm
sqrrm requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a good change, but since the verification is added I think it should be made automatic to be actually useful and not just add confusion.

desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/trade/DelayedPayoutTxValidation.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeView.java Show resolved Hide resolved
@chimp1984
Copy link
Contributor Author

Overall this is a good change, but since the verification is added I think it should be made automatic to be actually useful and not just add confusion.

The verification is not for the users themself but for DAO voter to verify a reimbursement request. So they have an easy way to verify. The trader need to copy paste the summary msg and voters verify it. They dont have the data so they could not do it automatically.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

Ah, that makes more sense. Could still add auto check for refund agent but that's less important I suppose.

@chimp1984
Copy link
Contributor Author

Ah, that makes more sense. Could still add auto check for refund agent but that's less important I suppose.

Yes sould be probably added. I will make a new PR for that once that is merged.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

Only thing left to fix is the log level, then merge.

@sqrrm
Copy link
Member

sqrrm commented Sep 25, 2020

@chimp1984 looks like there is a conflict now.

sqrrm
sqrrm approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 2c252e9 into bisq-network:master Sep 25, 2020
@chimp1984 chimp1984 deleted the dispute-agent-branch branch September 27, 2020 06:28
@ripcurlx ripcurlx added this to the v1.4.0 milestone Sep 30, 2020
@sqrrm sqrrm mentioned this pull request Oct 23, 2020
Closed
@sqrrm sqrrm mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @sqrrm @ripcurlx