Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning message regarding insufficient BSQ #4440

Merged
merged 1 commit into from Aug 29, 2020
Merged

Improve warning message regarding insufficient BSQ #4440

merged 1 commit into from Aug 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2020

Improve the warning message to explain why BSQ balances close to 5.46 are not sufficient to be used for trade fees, due to dust limits in the Bitcoin protocol.

Fixes #4439

image

Improve the warning message to explain why BSQ balances
close to 5.46 are not sufficient to be used for trade fees,
due to dust limits in the Bitcoin protocol.

Fixes #4439
@ghost ghost closed this Aug 27, 2020
@ghost ghost reopened this Aug 27, 2020
@ghost
Copy link
Author

ghost commented Aug 27, 2020

Close / Open to try the Travis build again. For some unknown reason it has been failing.

@ghost ghost closed this Aug 27, 2020
@ghost ghost reopened this Aug 27, 2020
@ripcurlx
Copy link
Contributor

@m52go Could you please proof read this and I'm happy to merge it.

@m52go
Copy link
Contributor

m52go commented Aug 28, 2020

ACK - looks like the same text I suggested in #4439 (comment).

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #4440 (comment)

@ripcurlx ripcurlx merged commit ecb8db3 into bisq-network:master Aug 29, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Aug 29, 2020
@ghost ghost deleted the fix_low_bsq_offer branch September 14, 2020 22:20
@ghost ghost mentioned this pull request Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING ABOUT 5.46 BSQ FLOOR
2 participants