Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload dispute layout on reopen #4438

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

sqrrm
Copy link
Member

@sqrrm sqrrm commented Aug 26, 2020

When a dispute is reopened it now shows the chat text entry field. Might help with bisq-network/roles#102 (comment)

When a dispute is reopened it now shows the chat text entry field.
@chimp1984
Copy link
Contributor

chimp1984 commented Aug 28, 2020

ACK

I think one problem is that users dont know the shortcut to re-open the dispute. I will look into that and might add a button to my other PR. For mediators a button instead of the shortcut is for sure a good idea. For users I am not that sure as they might overuse that. But maybe a warning popup might help....

It would be good as well that it auto-reopens if a message arrives as well that the number icon is updated, otherwise messages in closed disputes are easily overlooked.

@sqrrm sqrrm requested a review from ripcurlx August 28, 2020 21:20
@sqrrm
Copy link
Member Author

sqrrm commented Aug 28, 2020

The mediator can tell the user to use ctrl-u to reopen. Another option is a hover help to explain that, let's not add another popup.

@sqrrm sqrrm merged commit a148850 into bisq-network:master Aug 29, 2020
@sqrrm sqrrm deleted the reenable-chat-on-dispute-reopen branch August 29, 2020 12:18
@ripcurlx ripcurlx added this to the v1.3.8 milestone Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants