-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle messages at broadcast #4436
Bundle messages at broadcast #4436
Commits on Aug 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for badc872 - Browse repository at this point
Copy the full SHA badc872View commit details -
Configuration menu - View commit details
-
Copy full SHA for c493282 - Browse repository at this point
Copy the full SHA c493282View commit details
Commits on Aug 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5433707 - Browse repository at this point
Copy the full SHA 5433707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06f407f - Browse repository at this point
Copy the full SHA 06f407fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea50ce8 - Browse repository at this point
Copy the full SHA ea50ce8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8152d6 - Browse repository at this point
Copy the full SHA b8152d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04b6c2a - Browse repository at this point
Copy the full SHA 04b6c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8747da4 - Browse repository at this point
Copy the full SHA 8747da4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f67a467 - Browse repository at this point
Copy the full SHA f67a467View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6c56b3 - Browse repository at this point
Copy the full SHA c6c56b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59a3ad - Browse repository at this point
Copy the full SHA d59a3adView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8da20a - Browse repository at this point
Copy the full SHA d8da20aView commit details
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bef4700 - Browse repository at this point
Copy the full SHA bef4700View commit details -
- Add shutdown handling to broadCaster.
It is important that we flush our queued requests at shutdown and wait until broadcast is completed as a maker need to remove his offers at shutdown. - Add handling for the case that there are very few connections (as in dev setup). - Make BundleOfEnvelopes extend BroadcastMessage - Add complete handler for broadCaster to shutdown in P2PService and wait with shutdown of other services until broadcaster is completed. - Remove case for repeated shutdown call on P2PService as it cannot happen.
Configuration menu - View commit details
-
Copy full SHA for b1702f7 - Browse repository at this point
Copy the full SHA b1702f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e780d49 - Browse repository at this point
Copy the full SHA e780d49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6270527 - Browse repository at this point
Copy the full SHA 6270527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ff2df - Browse repository at this point
Copy the full SHA 21ff2dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e8704e - Browse repository at this point
Copy the full SHA 0e8704eView commit details
Commits on Aug 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 28a665e - Browse repository at this point
Copy the full SHA 28a665eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c535ebb - Browse repository at this point
Copy the full SHA c535ebbView commit details
Commits on Aug 29, 2020
-
Merge branch 'master_upstream' into bundle-msg-at-broadcast
# Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
Configuration menu - View commit details
-
Copy full SHA for be78770 - Browse repository at this point
Copy the full SHA be78770View commit details -
Merge remote-tracking branch 'origin/bundle-msg-at-broadcast' into bu…
…ndle-msg-at-broadcast # Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
Configuration menu - View commit details
-
Copy full SHA for 366fdb3 - Browse repository at this point
Copy the full SHA 366fdb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0eea78 - Browse repository at this point
Copy the full SHA b0eea78View commit details
Commits on Aug 30, 2020
-
Merge branch 'master_upstream' into bundle-msg-at-broadcast
# Conflicts: # p2p/src/main/java/bisq/network/p2p/P2PService.java
Configuration menu - View commit details
-
Copy full SHA for 6accd58 - Browse repository at this point
Copy the full SHA 6accd58View commit details -
Merge remote-tracking branch 'origin/bundle-msg-at-broadcast' into bu…
…ndle-msg-at-broadcast
Configuration menu - View commit details
-
Copy full SHA for 0aa97d3 - Browse repository at this point
Copy the full SHA 0aa97d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d13ff8 - Browse repository at this point
Copy the full SHA 8d13ff8View commit details -
I don't know why the tests failed as I just added an overloaded method and it should not have any impact. There is also one exception which makes it even more obscure. I guess its some test framework issue. See comment at the exceptional handling // If we remove the last argument (isNull()) tests fail. No idea why as the broadcast method has an / overloaded method with nullable listener. Seems a testframework issue as it should not matter if the // method with listener is called with null argument or the other method with no listener. We removed the // null value from all other calls but here we can't as it breaks the test.
Configuration menu - View commit details
-
Copy full SHA for 49d212e - Browse repository at this point
Copy the full SHA 49d212eView commit details
Commits on Aug 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for bc802c8 - Browse repository at this point
Copy the full SHA bc802c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7951d5 - Browse repository at this point
Copy the full SHA f7951d5View commit details