Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert usage of caffeinate on OSX #4407

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

chimp1984
Copy link
Contributor

It seems caffeinate is not preventing that Bisq gets throttled resources
once the OS switches to hibernate.
See: #4300 (comment)

It seems caffeinate is not preventing that Bisq gets throttled resources
once the OS switches to hibernate.
See:
bisq-network#4300 (comment)
@chimp1984
Copy link
Contributor Author

chimp1984 commented Aug 9, 2020

Just tested master version again. Bisq binary has about 50 offers after a few hours hibernate. Once activated it speeds up to > 400 offers. If I start the app from the IDE/src code it seems it does not fall into hibernate. Might be that the IDE keeps it alive for debugger or that it behaves differently if run as application.

@chimp1984
Copy link
Contributor Author

After more testing and feedback from @ripcurlx it seems the issues happens only if run as binary and not on all OSX version. I could reproduce it always with 10.12.6. Even without going to sleep mode the inactive app got throttled and lost most offers. As we do not know which versions are affected I recommend to revert to the old sound file solution.

@chimp1984
Copy link
Contributor Author

I will try to get the sound file smaller and the noise level lower as well.

Converted sound file to a 10 second mono noise with lower volume.
Tested with max possible sound volume and it was hardly audible.
Tested a binary built with it and I could not observe the network
degradation issues.
File is not 800 kb instead of 42 MB.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - as I never experienced the issue on my macOS version (Catalina) I can't test it properly. But I'm fine with rolling back to the previous solution which proved to work across versions.

@ripcurlx ripcurlx merged commit 943d1c3 into bisq-network:master Aug 19, 2020
@chimp1984 chimp1984 deleted the use-sound-loop-on-osx branch August 24, 2020 03:33
@ripcurlx ripcurlx added this to the v1.3.8 milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants