Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show signing state if signing for payment method is required #4396

Merged

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Aug 3, 2020

While testing the USPMO payment account for v1.3.7 I recognized that there is a display issue that surfaced because of #4305. We are signing all payment accounts with the exact same name to have already a couple of seeds if we need to enable account signing for other payment methods as well.

This wasn't handled properly in the offerbook.

Displaying 0 days for USPMO offer
Bildschirmfoto 2020-08-03 um 11 55 40

Should be N/A
Bildschirmfoto 2020-08-03 um 12 00 25

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 0931792 into bisq-network:master Aug 3, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Aug 24, 2020
@ripcurlx ripcurlx deleted the only-show-signing-state-when-needed branch July 16, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants