Create offer using the same tx fee specified at funding #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue whereby updates from the fee API were causing Insufficient Funds exception. Since the wallet is funded with a specific amount (deposit+trade fee+txFee), that same amount has to be used when the user confirms offer creation (which could be some time later). Fixes #4227 Fixes #4278 Fixes #4336 Fixes #4327
ripcurlx
changed the title
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue whereby updates from the fee API were causing Insufficient Funds exception. Since the wallet is funded with a specific amount (deposit+trade fee+txFee), that same amount has to be used when the user confirms offer creation (which could be some time later).
Fixes #4227
Fixes #4278
Fixes #4336
Fixes #4327