Add equals check to prevent resetting of newly set Filter #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #4294 I recognized that when adding a new filter object to the network one of my regtest nodes got its filter reset. This was caused by a timing issue that the added filter message was received before the removed filter message. In that case the filter was reset and the new filter never applied. This is only a problem during runtime when a new filter is set. After a restart the correct filter is applied. This PR adds a equals check to prevent the reseting of a filter by mistake. As the added filter message overwrites all fields anyways not having the removed filter message is not essential.