Increase price precision in Offer Book chart (altcoins) #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Offer Book Chart, altcoins were displayed with prices having only 3 decimal places of precision. This resulted in not being able to see any meaningful prices across the x-axis because they were all the same, e.g. ETH=0.025 Instead it should show 8 digits of precision for altcoins. So for example ETH=0.02456914 Change the rule from if price begins 0.000 then display higher precision, to if price begins 0.0 then display higher precision. Fixes #4251
|
XMR before |
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Offer Book Chart, altcoins were displayed with prices having only 3 decimal places of precision. This resulted in not being able to see any meaningful prices across the x-axis because they were all the same, e.g. ETH=0.025
Instead it should show 8 digits of precision for altcoins. So for example ETH=0.02456914
Change the rule for display of altcoin Offer Book chart from:
if price begins 0.000 then display higher precisionto:
if price begins 0.0 then display higher precisionFiat currency chart not affected by this rule.
Fixes #4251