Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when restoring wallet seedwords without date #4283

Merged
merged 1 commit into from Jun 14, 2020
Merged

Warn when restoring wallet seedwords without date #4283

merged 1 commit into from Jun 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 4, 2020

When the user restores a BIP39 wallet from seed words there is an optional 'wallet date' field. If the user does not enter that field the chain scan will be a lengthy process. Issue a popup message to the user in this case, informing them that the synch will take a long time and can be reduced by either specifying the wallet creation date or the date when Bisq introduced BIP39 seed words.

Fixes #3766

When the user restores a BIP39 wallet from seed words there is
an optional 'wallet date' field.  If the user does not enter that
field the chain scan will be a lengthy process.
Issue a popup message to the user in this case, informing them
that the synch will take a long time and can be reduced by either
specifying the wallet creation date or the date when Bisq introduced
BIP39 seed words.

Fixes #3766
@ghost ghost changed the title Warning when restoring wallet seedwords without date Warn when restoring wallet seedwords without date Jun 4, 2020
@ghost ghost marked this pull request as draft June 5, 2020 03:47
@ghost ghost mentioned this pull request Jun 11, 2020
@ghost ghost marked this pull request as ready for review June 11, 2020 22:46
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm added this to the v1.3.6 milestone Jun 14, 2020
@sqrrm sqrrm merged commit 6aae5eb into bisq-network:master Jun 14, 2020
@ghost ghost mentioned this pull request Jul 12, 2020
@ghost ghost deleted the restore_wallet_date_empty_feedback branch September 14, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide feedback when attempting to restore a wallet from seed words without specifying a date
1 participant