Secondary sort order for offer book (rewrite) #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rewrite of @freimair's PR bisq-network#4168. Adds a secondary sort order of offers in market offer book by offer amount that goes from high to low. Also, refactors-away overcomplicated previous implementation of primary sort. Co-authored-by: Florian Reimair <office@florianreimair.at> Co-authored-by: cd2357 <15956136+cd2357@users.noreply.github.com>
dmos62
changed the title
|
The class |
ghost
approved these changes
May 16, 2020
ghost
suggested changes
May 25, 2020
desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java
Show resolved
Hide resolved
|
@jmacxx thanks again! Fixed the ordering. I hadn't noticed that the tables are switched in Altcoin markets. Included an in-code explanation. |
ghost
approved these changes
May 25, 2020
sqrrm
approved these changes
May 25, 2020
| @@ -276,22 +276,32 @@ private boolean isAnyPricePresent() { | |||
| } | |||
|
|
|||
| private void updateChartData() { | |||
|
|
|||
There was a problem hiding this comment.
Prefer no blank lines at the beginning of methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4168. This is a rewrite of that PR.
Adds a secondary sort order to offers in market offer book by offer amount that goes from high to low. Also, replaces previous complicated implementation of primary sort.
Co-authored-by: @freimair
Co-authored-by: @cd2357