Bugfixes related to switch statements #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-bug; only effect that the other instanceof is always evaluated.
This omission is currently not disruptive, since the next case clause only contains a break.
Without the break statement, the execution would continue through the subsequent case clauses until it encountered a break, executing `checkArgument` calls meant for `REIMBURSEMENT_MAX_AMOUNT`. More specifically, the bug would cause a failed check in the case where `inputValueAsCoin.value <= 200000000` is false.
Manfred [0] pointed out that COMPENSATION_REQUEST_MIN_AMOUNT and REIMBURSEMENT_MIN_AMOUNT should be checked for not exceeding 200k BSQ too. [0] https://github.com/bisq-network/bisq/pull/4212/files/4ec6bac658ca5c8e3cd4d4a9e0ac7207bac8799b..fb76fd65481e882ae0e232c3d8c1814e29a9e878#r420249962
|
For the Also adding a test for validator is (I believe) technically easy (in contrast to some UI changes). |
sqrrm
reviewed
May 25, 2020
There was a problem hiding this comment.
utACK
@ManfredKarrer I still need your review on this to be able to merge, but I think this is a reasonable and safe change.
sqrrm
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second go at #4212, which was reverted. The previous PR was fixing some problems with switch statements and a typo where a short-circuit boolean operator was used without need. This PR is the same as the last one, but the semantic/cosmetic changes (why the original PR was reverted) are removed and it also implements a suggestion by @ManfredKarrer to add a (forgotten) check.