OfferBook: Show min-max range for amount and volume #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OfferBook tables now show the amount and the volume as min-max range, where appropriate. For the offers that have no range defined, the single values are shown. Fixes bisq-network#3129
cd2357
force-pushed
the
show-min-max-orderbook
branch
from
3e2ce3d
to
34ff2d6
Compare
sqrrm
requested changes
May 5, 2020
|
Adding screenshots: Before (buy and sell offers in the Offerbook did not show the min-max range) :
After (both buy and sell orders now show the min-max range, for volume and price) :
|
ghost
reviewed
May 10, 2020
|
|
||
| /** | ||
| * Renders cell content, if it has a single value or a range. | ||
| * Should not be called for empty cells |
There was a problem hiding this comment.
Is this comment really needed? Maybe naming renderCellContent() is enough as it is private method in very specific context.
|
ACK |
|
@petrhejna Thanks for reviewing. Did you read up on the usage of ACK, utACK and NACK? ACK meaning you have actually tested this PR. |
|
@sqrrm yes, I did test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OfferBook tables now show the amount and the volume as min-max range, where appropriate.
For the offers that have no range defined, the single values are shown.
Fixes #3129