Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject expired data and log with debug level #4217

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Reject expired data and log with debug level #4217

merged 4 commits into from
Apr 30, 2020

Commits on Apr 29, 2020

  1. If a new received protectedStorageEntry is expired we do not store it 

    and do not broadcast.

It is unclear why we receive expired data (some are very old), but a
manipulated node might produce that and as it only removed at each
batch process running each minute to clean out expired data it still
could propagate. Is an attack vector also to flood the network with
outdated offers where the maker is likely not online.

Should fix bisq-network#4026
    @chimp1984
    chimp1984 committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    d962880 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Fix typo in log statement

    @ripcurlx
    ripcurlx committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    c57e73b View commit details
    Browse the repository at this point in the history

  2. Make verbose log debug level

    @sqrrm
    sqrrm committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    0047f4d View commit details
    Browse the repository at this point in the history

  3. Make initial logging also debug level 

    Should be set to warn level again with next release v1.3.5
    @ripcurlx
    ripcurlx committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    7f0b76e View commit details
    Browse the repository at this point in the history