Permutation fix #4206
Permutation fix #4206
Conversation
WIP, needs more tests, comments, clean up....
We add a second button (displayed as first) to the preferences UI for resync from latest resources. We add a warning to the resync from genesis as it takes very long time and causes heavy network load for seeds. The resync button at the stateMonitor does now a resync from resources, not from genesis. We add handling of the UnconfirmedBsqChangeOutputList file as well. In Filemanager we add a check if file exists.
The getAllConnections() call in the while loop always returned the same number of nodes so the timeout of 15 sec was always triggered. We now wait for the shutdown handlers of the connections and if all are called we run our handler. If it takes longer as our timeout of 3 sec. the shutdown handler gets called by the timeout.
sqrrm
requested review from
ManfredKarrer and
ripcurlx
and removed request for
ManfredKarrer
There was a problem hiding this comment.
Tested OK on jhgc seednode, however feedback is the same as testing chimp's PR where the proposal is rejected and then somehow approved 2 seconds later - is that expected?
Apr-29 09:04:04.178 [SeedNodeMain] WARN b.c.d.g.v.VoteResultService: We have a proposal which was not part of our blind vote and reject it. Proposal ={}CompensationProposal{
requestedBsq=455300,
bsqAddress='B1F1qJTNUhVPukeqgee9WmLNBkMjm6DTFEY'
} Proposal{
txId='8e24ad18fc892451e01e8032aa5725a750a6a3b2df152da74264160f3f8784cd',
name='wiz',
dao-compensation/547',
txId='8e24ad18fc892451e01e8032aa5725a750a6a3b2df152da74264160f3f8784cd',
version=1,
creationDate=Mon Apr 20 06:49:21 UTC 2020
}
Apr-29 09:04:06.408 [SeedNodeMain] INFO b.c.d.g.v.i.IssuanceService:
################################################################################
We issued new BSQ to tx with ID 8e24ad18fc892451e01e8032aa5725a750a6a3b2df152da74264160f3f8784cd
Issued BSQ: 455300
Issuance type: COMPENSATION
################################################################################
There was a problem hiding this comment.
ACK
Tested OK on a Bisq SPV node configured to use the above seednode running this PR. Pressing the "re-sync DAO from resources" button resulted in the cycle 12 vote results appearing with 23 blind votes as expected. Final state hashes match my other nodes:
DAO state @ 628132 = 7b61e887
proposals @ 626977 = 24fa24222
blind votes @ 627437 = 01d8e01b
Can confirm those hashes with one full node and one lite node resynced from latest resources and using the new permutation algo. |
|
ACK |
Change the permutation algo to check each permutation as it's created and minimize memory usage. Start with longer lists and remove one item per level. Avoid duplicates by not removing the same item twice.