Limit abuse of --useLocalhostForP2P option
#4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the --useLocalhostForP2P option could be used even for BTC_MAINNET. That is bad and caused mediation cases.
Still better than having failed trades without the possibility of communication. |
ripcurlx
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
ACK
Tested it on Regtest with different scenarios:
- Not passing a
BASE_CURRENCY_NETWORKand usingUSE_LOCALHOST_FOR_P2Pfails with
error: problem parsing option 'useLocalhostForP2P': Option(s) [useLocalhostForP2P] are unavailable given other options on the command line - Setting Mainnet as base currency network defaults
USE_LOCALHOST_FOR_P2Pto false. - Setting Regtest as base currency network still allows
USE_LOCALHOST_FOR_P2Pto get set.
|
Tails is up again: https://bisq.wiki/Bisq_on_tails thus, the issues #3927, #2278, #3791, #2841 can finally be closed properly (most of them already have been dropped already anyways) |
ripcurlx
added
the
is:priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4152, fixes #4123, fixes #3927
Until now, the
--useLocalhostForP2Poption could be used even forBTC_MAINNET. Even though the option has been clearly labelled to be for development purposes, it found its way into setup guides for eg. the Tails OS.This PR only allows the option if the base currency network is set to something other than
BTC_MAINNET.That of course will most likely prevent users on Tails OS to use Bisq. Will look into the Tails stuff soon and followup on this one.