Pricenode crashes on startup due to CoinMarketCap retired API #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
changed the title
|
From reading the comments on how the Providers are instantiated, this looks fine. I don't understand exactly how that's done though, would really prefer the review of @cbeams |
wiz
changed the title
With the removal of CoinMarketCap as an exchange rate provider in the prior commit, the @order values of the remaining three provider implementations are non-contiguous. CoinMarketCap was @order(3) and with it gone, the remaining order values became 1, 2, 4. This is not a problem in practice, but could be confusing for future maintainers, so this commit simply decrements the Poloniex implementation from 4 to 3 in order to make the values contiguous once again. This commit also fixes a typo in ExchangeRateProvider's Javadoc.
|
Again please note that this PR is an emergency measure since currently pricenodes crash on startup. Obviously we need to consider implementing one of the new CMC authenticated / paid APIs to replace the API that has been retired |
cbeams
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
CoinMarketCap isn't actively used as a pricenode provider, because the only coins that used it have been delisted.
Issue
CoinMarketCap has retired their v1 API, and the resulting
HTTP 410 Gonecauses the pricenode to crash on startupSummary
This PR simply removes CoinMarketCap as a PriceNodeProvider since it's apparently no longer used and the API has been retired