Size the offer book on window activation #4031
Conversation
|
Thanks for opening this pull request! |
|
@jmacxx Thanks for your first PR! I'll review your PR now, but please adapt and force push your commit message based on bisq-network/style#9. I don't want to be picky, but I think it is good to follow this guideline for your future contributions. Thanks! |
There was a problem hiding this comment.
NACK
ACK from functionality and code changes. As soon as you have updated the commit message #4031 (comment) I'm happy to merge your PR.
ghost
requested a review
from
|
@jmacxx Please sign your commit. Thanks! |
Currently the offer book tables are only being sized when the window proportions change. However if the window is made bigger before the offer book is opened, then the tables are not resized from their default. Other windows (for example Market -> Trades) solve this by make a sizing call in the activate method. In order to do this the sizing code is separated into a layout method where it can be called from both activate and the existing heightProperty listener. The same approach is taken here. Fixes #4030
ghost
mentioned this pull request
Fixes #4030
Currently the offer book tables are only being sized when the window proportions change. However if the window is made bigger before the offer book is opened, then the tables are not resized from their default.
Other windows (for example Market -> Trades) solve this by make a sizing call in the
activatemethod. In order to do this the sizing code is separated into alayoutmethod where it can be called from bothactivateand the existingheightPropertylistener. The same approach is taken here.