Speed up BSQ supply view load #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Java Time instead of java.sql.Date for local date calculations; * Avoid raw types & unsafe varargs warnings; * Fix false compiler error in IDEA due to discrepancy with javac; * Formatting & method visibility.
Avoid repeatedly calling DaoFacade.getBlockTime for Issuance objects with the same chain height, as that method linearly scans the entire linked list of DaoState blocks, making it quite slow. Instead, memoise the mapping from chain height to block-time month, so that it is only computed once per graph point instead of once for every BSQ issuance.
ripcurlx
approved these changes
Feb 17, 2020
ripcurlx
added
the
is:priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying the monthly BSQ issued series, avoid repeatedly calling
DaoFacade.getBlockTimefor Issuance objects with the same chain height, as that method linearly scans the entire linked list ofDaoStateblocks, making it quite slow. Instead, memoise the mapping from chain height to block-time month, so that it is only computed once per graph point instead of once for every BSQ issuance.Also do some minor cleanup of
SupplyView, including a compilation error flagged incorrectly by IntelliJ, caused by the raw typed constructor referenceXYChart.Data::new.--
Repeatedly switching to the BSQ Supply tab under Facts & Figures revealed the following minor hotspot in JProfiler (fixed by the above):