Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random BSQ block explorer selection by setting Nullable #3802

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Fix random BSQ block explorer selection by setting Nullable #3802

merged 1 commit into from
Dec 18, 2019

Conversation

wiz
Copy link
Member

@wiz wiz commented Dec 18, 2019

After more testing I found a bug in #3792 that would not always use the random selector, should be fixed now. Testcase:

  1. Erase data dir
  2. Start Bisq
  3. Check value of settings -> BSQ block explorer
  4. Repeat a bunch of times
    [Expected Result]
    BSQ block explorer should be randomly selected (i.e. different sometimes)

@wiz wiz requested a review from ripcurlx as a code owner December 18, 2019 08:57
ripcurlx
ripcurlx approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Missed this in my last review as well

@ripcurlx ripcurlx merged commit 8a279c7 into bisq-network:master Dec 18, 2019
@wiz wiz deleted the fix-bsq-explorer-always-picking-wiz branch December 18, 2019 14:21
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wiz @ripcurlx