Vote Reveal - Silent Fail

[niyid]

Fixes #3408

The log below shows where the vote reveal failed silently as a result of insufficient wallet balance.

Oct-15 06:43:21.835 [JavaFX Application Thread] INFO  org.bitcoinj.wallet.Wallet: Completing send tx with 1 outputs totalling 0.00000596 BTC and a fee of 0.00 BTC/kB 
Oct-15 06:43:21.837 [JavaFX Application Thread] WARN  org.bitcoinj.wallet.Wallet: Insufficient value in wallet for send: needed 0.00001606 BTC more 
Oct-15 06:43:21.845 [JavaFX Application Thread] ERROR b.c.d.g.v.VoteRevealService: VoteRevealException{
     voteRevealTx=null,
     blindVoteTxId='3cf435e275b8e1518ea969fe90e0504bbed1d68135310b3c24546244fca90b5d',
     myVote=null
} bisq.core.dao.governance.votereveal.VoteRevealException: Exception at calling revealVote. 
Oct-15 06:43:24.448 [JavaFX Application Thread] INFO  b.c.d.m.DaoStateMonitoringService: Passed checkpoint Checkpoint {
     height=586920,
     hash=523aaad4e760f6ac6196fec1b3ec9a2f42e5b272
} 

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[chimp1984]

Still relevant

[niyid]

Still relevant

Great. Awaiting review.

[ripcurlx]

NACK - Please see my comment. Would also be great if you could rebase your PR to master. Makes it easier for testing using the most up-to-date codebase.

[ripcurlx]

NACK - Please see my comment

[ripcurlx]

NACK

It does show it correctly when you start the app

But it will show you now every time on startup without the chance of getting rid of it again.
I think it would be good to add a don't show again flag to this popup so the user can decide if he want to see the warning for this transaction vote reveal again.

[ripcurlx]

NACK

Did you try this out?
That won't work. It still would be shown each time as you need to check if the key was set before you open the popup. Also we don't want to ask once and hide all popups afterwards, we want to show it at least once for each different transaction failure. So that means you need to extend the key with the tx id.

[ripcurlx]

NACK

Formatting broken.

[ripcurlx]

NACK - I think you checked in some changes for .idea/codeStyles/Project.xml by mistake.

[ripcurlx]

NACK

Please see my comments. Also please rebase your PR so it is easier to test locally and I think it will remove one necessary change you did to the editorconfig file. Actually my checkstyle configuration should now catch this issues, but somehow running a recheck didn't do the trick yet.

[ripcurlx]

ACK

Tested it on local Regtest and it finally does what it is intended to do.

[sqrrm]

This PR touches core DAO code so it should be ACKed by manfred according to our merge rules.

[ripcurlx]

This PR touches core DAO code so it should be ACKed by manfred according to our merge rules.

Not sure if a ACK by @ManfredKarrer is necessary in that case as it just surfaces an exception thrown during the vote reveal process. But in any case I mentioned now Manfred if he wants to give it an ACK as well.

[sqrrm]

I think sticking to this rule would be good.

[ripcurlx]

Ok - I'll ping @ManfredKarrer for an ACK.

[chimp1984]

NACK. See last comment. I would suggest to revert that PR and be more critical on dao package changes.