Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

List Lobstex (LOB) #28

Merged
merged 2 commits into from
Jun 30, 2018
Merged

List Lobstex (LOB) #28

merged 2 commits into from
Jun 30, 2018

Conversation

lobstex
Copy link
Contributor

@lobstex lobstex commented Jun 5, 2018

Author: lobstex@gmail.com
Official project URL: https://lobstex.com/lobstex-1
Official block explorer URL: http://explorer.lobstex.com/

@0xConsole
Copy link

Any response on this?

Copy link
Collaborator

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK per comments

Apply Bisq code style to both java files.


public class LobstexCoin extends Coin {
public LobstexCoin() {
super("Lobstex", "LOBS", new DefaultAddressValidator());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use deprecated DefaultAddressValidator

@cbeams
Copy link
Member

cbeams commented Jun 29, 2018

I'll close this soon if there isn't a commit following up on @blabno's NACK.

@lobstex
Copy link
Contributor Author

lobstex commented Jun 29, 2018

I've changed the source to reflect @blabno 's change requests.

Copy link
Member

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. See my additional fixes in 66002e0.

@cbeams cbeams merged commit 26e8748 into bisq-network:master Jun 30, 2018
cbeams added a commit that referenced this pull request Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants