fix: use byte length for strings #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec has been clarified on how string length should be evaluated, see biscuit-auth/biscuit#159 tl;dr: string length is a minefield and no two languages do it consistently (and one could argue that no language does it properly). Since cross-language compatibility is a core tenet of biscuit, let's do the thing that's guaranteed to work across languages: counting bytes in the utf8-encoded representation
Geal
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec has been clarified on how string length should be evaluated, see biscuit-auth/biscuit#159
tl;dr: string length is a minefield and no two languages do it consistently (and one could argue that no language does it properly).
Since cross-language compatibility is a core tenet of biscuit, let's do the thing that's guaranteed to work across languages: counting bytes in the utf8-encoded representation