Added support for builtin list. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
approved these changes
Sep 3, 2021
| self.stack.push(Value::List(items)); | ||
| Ok(()) | ||
| } | ||
| _ => self.error(ErrorCode::InvalidValue("set() arg".into())), |
There was a problem hiding this comment.
This should be list() arg I think.
|
Nightly failure is due to rust-num/num-bigint#218 |
|
Thanks for the PR! I've released 0.6.3 with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset memoize to support streaming multiple objects.
By default
(value_)from_readercloses the input stream. It is possibleto deserialize multiple pickle objects from a single stream by
implementing a custom reader.
This patch will reset the memoize at the beginning when a new object is
deserialized. Any refs would then point to the correct object inside the memoize.
We checked several approaches but this approach seems to fit best (support most
protocols) however this might not be the obvious place.