skip conda in Makefile #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
reviewed
Sep 10, 2019
| @echo " pep8 to run pep8 code style checks." | ||
| @echo " test to run tests (but skip long running tests)." | ||
| @echo " test-all to run all tests (including long running tests)." | ||
| @echo " lint to run code style checks with flake8." |
There was a problem hiding this comment.
This is a welcome change. Some other projects include Black formatting. This leaves an opening for the discussion.
Zeitsperre
reviewed
Sep 10, 2019
| @@ -47,7 +47,9 @@ | |||
| packages=find_packages(), | |||
| include_package_data=True, | |||
| install_requires=reqs, | |||
| extra_requires=extra_reqs, | |||
| extras_require={ | |||
| "dev": dev_reqs, # pip install ".[dev]" | |||
Zeitsperre
approved these changes
Sep 10, 2019
|
@Zeitsperre thanks for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the conda environment handling from the Makefile. The conda environment needs to be created manually and is optional. This is a change already done in Twitcher and Birdy.
Changes:
setup.pyRelated Issue / Discussion
Additional Information
When this is accepted I can update also the cookiecutter.