Use black formatting check #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
approved these changes
Jan 13, 2021
| assert ( | ||
| utils.delist( | ||
| [ | ||
| "one", |
There was a problem hiding this comment.
Suggested change
| "one", | |
| "one" |
Then re-run pre-commit run --all-files
| [ | ||
| "application/gml+xml", | ||
| "application/zip", | ||
| "application/x-zipped-shp", |
There was a problem hiding this comment.
Suggested change
| "application/x-zipped-shp", | |
| "application/x-zipped-shp" |
| "LSJ_LL.zip", | ||
| [ | ||
| "application/gml+xml", | ||
| "application/x-zipped-shp", |
There was a problem hiding this comment.
Suggested change
| "application/x-zipped-shp", | |
| "application/x-zipped-shp" |
| run: make lint | ||
| if: matrix.python-version == 3.8 | ||
| - name: Check formatting with black ⚙️ | ||
| run: black --check --target-version py38 birdy tests |
There was a problem hiding this comment.
Suggested change
| run: black --check --target-version py38 birdy tests | |
| run: black --check --target-version py36 birdy tests |
I wouldn't put the conventions up to py38 if we are supporting building on platforms starting at py36. Could potentially introduce new features not supported in python<3.8.
| hooks: | ||
| - id: black | ||
| language_version: python3 | ||
| args: ["--target-version", "py38"] |
There was a problem hiding this comment.
Suggested change
| args: ["--target-version", "py38"] | |
| args: ["--target-version", "py36"] |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes adds
blackformatting.Changes:
black.pre-commit.setup.cfgandsetup.py.Related Issue / Discussion
Additional Information
Links to other issues or sources.