-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused geoserver dockerfiles #353
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1813/Result : failure BIRDHOUSE_DEPLOY_BRANCH : remove-unused-geoserver-dockerfile DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-88.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1216/NOTEBOOK TEST RESULTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got some formatting issues in the change logs.
The features themselves are good.
CHANGES.md
Outdated
[//]: # (list changes here, using '-' for each new entry, remove this when items are added) | ||
## Changes | ||
|
||
- Delete unused Dockerfiles, fixes #349 and #352 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR numbers and commit hash should use the full URL for generated docs (here and below)
CHANGES.md
Outdated
* birdhouse/docker/geoserver: not used since 3-4 years, replaced by https://github.com/kartoza/docker-geoserver | ||
|
||
* birdhouse/config/geoserver/Dockerfile: was introduced in commit f3b9896e6b771e0aff62c6851c2376d730ddadaf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use code format for paths
(PR #233, commit d1ecc63284ec9d2940bfa2b1b4baca3fbe1308b3) as a temporary | ||
solution only, not needed with newer kartoza docker images. | ||
|
||
- Move birdhouse/docker/solr to birdhouse/deprecated-components/solr/docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the path reference format (see example in below version).
Not tagging since this do not have any active code change. This is akin to simple documentation change. |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1987/Result : failure BIRDHOUSE_DEPLOY_BRANCH : remove-unused-geoserver-dockerfile DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-20.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1274/NOTEBOOK TEST RESULTS |
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1988/Result : failure BIRDHOUSE_DEPLOY_BRANCH : remove-unused-geoserver-dockerfile DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-35.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1275/NOTEBOOK TEST RESULTS |
Delete unused Dockerfiles, fixes 🛡️ [Security] Remove deprecated GeoServer #349 and fixes [Snyk] Security upgrade tomcat from 8.0-jre8 to 8.5.91-jre8 #352
birdhouse/docker/geoserver: not used since 3-4 years, replaced by https://github.com/kartoza/docker-geoserver
birdhouse/config/geoserver/Dockerfile: was introduced in commit f3b9896 (PR GeoServer: enable metadata-plugin for modifying layer metadata, including bulk modifications #233, merge commit d1ecc63) as a temporary solution only, not needed with newer kartoza docker images.
Move birdhouse/docker/solr to birdhouse/deprecated-components/solr/docker to group related files together. Solr has been deprecated since PR Deprecated unused/unmaintained components #311 (merge commit a8d3612).