Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fast whitespace split if no quoted values are in line #722

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

padix-key
Copy link
Member

@padix-key padix-key commented Dec 18, 2024

This PR introduces a shortcut for CIF line splitting (the speed limiting step of CIFFile) if the line contains no quoted value. This is the case for almost all lines.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #722 will improve performances by 33.9%

Comparing padix-key:cif-performance (88bdf50) with main (0acb143)

Summary

⚡ 3 improvements
✅ 44 untouched benchmarks

Benchmarks breakdown

Benchmark main padix-key:cif-performance Change
benchmark_deserialize_pdbx[cif] 114.5 ms 90.7 ms +26.15%
benchmark_get_structure[cif-False] 77 ms 57.5 ms +33.9%
benchmark_get_structure[cif-True] 137.5 ms 117.9 ms +16.61%

@padix-key padix-key merged commit c21a2ae into biotite-dev:main Dec 20, 2024
28 checks passed
@padix-key padix-key deleted the cif-performance branch January 17, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant