Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delete css.formatter.indentSize param #513

Merged
merged 1 commit into from
Jun 5, 2024
Merged

docs: delete css.formatter.indentSize param #513

merged 1 commit into from
Jun 5, 2024

Conversation

Marukome0743
Copy link
Contributor

Summary

css.formatter.indentSize was renamed css.formatter.indentWidth at biomejs/biome#2790.

Unlike the other deprecated indentSize options (e.g. formatter.indentSize),
css.formatter.indentSize doesn't work anymore.

That's why css.formatter.indentSize should be deleted.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 5eca573
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/665fd0ad80d3070008d45c81
😎 Deploy Preview https://deploy-preview-513--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Sec-ant Sec-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes I believe this is a leftover. CSS formatter wasn't a thing before v1.8 and there's no point introducing a deprecated option in a new feature. That's why indentSize isn't a deprecated alias for the CSS formatter like other ones.

Thank you!

@Sec-ant Sec-ant merged commit ef2d8f1 into biomejs:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants