Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n setup and some Japanese translation #887

Merged
merged 7 commits into from
Nov 26, 2023

Conversation

Gumichocopengin8
Copy link
Contributor

Summary

Partial work of #880

Test Plan

  • Check if i8n is ready to go
  • Check if home and 404 pages are translated in Japanese

@github-actions github-actions bot added the A-Website Area: website label Nov 26, 2023
@Gumichocopengin8 Gumichocopengin8 changed the title Feature/translation setup feat: i8n setup and some Japanese translation Nov 26, 2023
@Gumichocopengin8 Gumichocopengin8 marked this pull request as ready for review November 26, 2023 03:43
@nissy-dev nissy-dev changed the title feat: i8n setup and some Japanese translation feat: i18n setup and some Japanese translation Nov 26, 2023
Copy link
Contributor Author

@Gumichocopengin8 Gumichocopengin8 Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need to setup starlight UI translation for now since lots of languages are translated by default.

Arabic, Chinese, Czech, Danish, Dutch, English, French, Galician, German, Hebrew, Hindi, Indonesian, Italian, Japanese, Korean, Norwegian Bokmål, Persian, Portuguese, Romanian, Russian, Spanish, Swedish, Turkish, Ukrainian, and Vietnamese translated UI strings are provided out of the box, and we welcome contributions to add more default languages.

https://starlight.astro.build/guides/i18n/#translate-starlights-ui

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, we actually need it for 404

Copy link
Contributor Author

@Gumichocopengin8 Gumichocopengin8 Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nissy-dev ここの404ページ用に必要なのですが、import { defineCollection } from "astro:content";astro.config.tsにセットするとCannot find module 'astro:content' or its corresponding type declarations.のエラーが出てうまく使えないのですが解決方法とかわかりますか?withastro/astro#5711 を参考にしてみたのですが解決できませんでした。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一通り withastro/astro#5711 のコメントの解決策を試してみたのですがうまくいかなかったので別PRで解決策を探してみます。

@Gumichocopengin8 Gumichocopengin8 force-pushed the feature/translation-setup branch from 3d09c12 to 32a02a0 Compare November 26, 2023 03:57
Copy link
Contributor

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(翻訳 PR なので、日本語でやり取りも OK にしようと思います。)

まずは最初の翻訳してもらってありがとうございます!基本的には LGTM です!
いくつかコメントもらったところに返信したので確認お願いします 🙇

@unvalley unvalley self-requested a review November 26, 2023 09:30
@nissy-dev nissy-dev merged commit 222ef91 into biomejs:main Nov 26, 2023
@nissy-dev
Copy link
Contributor

Thanks 🚀

@Gumichocopengin8 Gumichocopengin8 deleted the feature/translation-setup branch November 26, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants