-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: i18n setup and some Japanese translation #887
feat: i18n setup and some Japanese translation #887
Conversation
website/astro.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need to setup starlight UI translation for now since lots of languages are translated by default.
Arabic, Chinese, Czech, Danish, Dutch, English, French, Galician, German, Hebrew, Hindi, Indonesian, Italian, Japanese, Korean, Norwegian Bokmål, Persian, Portuguese, Romanian, Russian, Spanish, Swedish, Turkish, Ukrainian, and Vietnamese translated UI strings are provided out of the box, and we welcome contributions to add more default languages.
https://starlight.astro.build/guides/i18n/#translate-starlights-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, we actually need it for 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nissy-dev ここの404
ページ用に必要なのですが、import { defineCollection } from "astro:content";
をastro.config.ts
にセットするとCannot find module 'astro:content' or its corresponding type declarations.
のエラーが出てうまく使えないのですが解決方法とかわかりますか?withastro/astro#5711 を参考にしてみたのですが解決できませんでした。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一通り withastro/astro#5711 のコメントの解決策を試してみたのですがうまくいかなかったので別PRで解決策を探してみます。
3d09c12
to
32a02a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(翻訳 PR なので、日本語でやり取りも OK にしようと思います。)
まずは最初の翻訳してもらってありがとうございます!基本的には LGTM です!
いくつかコメントもらったところに返信したので確認お願いします 🙇
Thanks 🚀 |
Summary
Partial work of #880
Test Plan