Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/noUselessConstructor): ignore constructor with default params #71

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Conaclos
Copy link
Member

Summary

Fix rome#4781

Test Plan

New test included

@Conaclos Conaclos temporarily deployed to Website deployment August 25, 2023 16:11 — with GitHub Actions Inactive
@Conaclos Conaclos marked this pull request as ready for review August 25, 2023 16:11
@Conaclos Conaclos requested a review from ematipico August 25, 2023 16:11
@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Aug 25, 2023
@Conaclos Conaclos changed the title fix(lint/noUselessConstructor): ignore constructor with default param… fix(lint/noUselessConstructor): ignore constructor with default params Aug 25, 2023
@ematipico ematipico merged commit c6c53b3 into main Aug 25, 2023
@ematipico ematipico deleted the conaclos/lint/noUselessConstructor/rome4781 branch August 25, 2023 16:53
@Conaclos Conaclos added the A-Changelog Area: changelog label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 noUselessConstructor removes default properties
2 participants