Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add noHeadImportInDocument rule #4184

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

kaioduarte
Copy link
Contributor

Summary

Implement no-head-import-in-document from eslint-plugin-next.

Test Plan

Snapshots + CI

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Oct 6, 2024
Copy link

codspeed-hq bot commented Oct 6, 2024

CodSpeed Performance Report

Merging #4184 will degrade performances by 6.91%

Comparing kaioduarte:no-head-import-in-document (9e38397) with main (03937c7)

Summary

❌ 1 regressions
✅ 104 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kaioduarte:no-head-import-in-document Change
router_17129688031671448157.ts[cached] 2.1 ms 2.2 ms -6.91%

@kaioduarte kaioduarte changed the title feat(lint): add no-head-import-in-document from eslint-plugin-next feat(lint): add noHeadImportInDocument from eslint-plugin-next Oct 6, 2024
@kaioduarte kaioduarte changed the title feat(lint): add noHeadImportInDocument from eslint-plugin-next feat(lint): add noHeadImportInDocument rule Oct 6, 2024
@kaioduarte kaioduarte force-pushed the no-head-import-in-document branch from 537e720 to e906804 Compare October 7, 2024 10:16
@kaioduarte

This comment was marked as resolved.

@kaioduarte kaioduarte force-pushed the no-head-import-in-document branch from e906804 to 0bbf671 Compare October 7, 2024 10:35
@ematipico ematipico merged commit 10fa910 into biomejs:main Oct 9, 2024
11 of 12 checks passed
@kaioduarte kaioduarte deleted the no-head-import-in-document branch October 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants