-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add noHeadImportInDocument
rule
#4184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
Area: CLI
A-Project
Area: project
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
A-Diagnostic
Area: diagnostocis
labels
Oct 6, 2024
CodSpeed Performance ReportMerging #4184 will degrade performances by 6.91%Comparing Summary
Benchmarks breakdown
|
ematipico
reviewed
Oct 6, 2024
...s/biome_js_analyze/tests/specs/nursery/noHeadImportInDocument/pages/_document/index.jsx.snap
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_head_import_in_document.rs
Outdated
Show resolved
Hide resolved
kaioduarte
changed the title
feat(lint): add
feat(lint): add Oct 6, 2024
no-head-import-in-document
from eslint-plugin-next
noHeadImportInDocument
from eslint-plugin-next
kaioduarte
changed the title
feat(lint): add
feat(lint): add Oct 6, 2024
noHeadImportInDocument
from eslint-plugin-next
noHeadImportInDocument
rule
kaioduarte
force-pushed
the
no-head-import-in-document
branch
from
October 7, 2024 10:16
537e720
to
e906804
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kaioduarte
force-pushed
the
no-head-import-in-document
branch
from
October 7, 2024 10:35
e906804
to
0bbf671
Compare
ematipico
reviewed
Oct 7, 2024
crates/biome_js_analyze/src/lint/nursery/no_head_import_in_document.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_head_import_in_document.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_head_import_in_document.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_head_import_in_document.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CLI
Area: CLI
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement no-head-import-in-document from eslint-plugin-next.
Test Plan
Snapshots + CI