-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(parse/json): change fields in JsonParserSettings
to Option
#3272
Merged
Sec-ant
merged 1 commit into
biomejs:main
from
dyc3:06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
Jun 25, 2024
Merged
refactor(parse/json): change fields in JsonParserSettings
to Option
#3272
Sec-ant
merged 1 commit into
biomejs:main
from
dyc3:06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
Area: project
A-Parser
Area: parser
L-JSON
Language: JSON and super languages
labels
Jun 24, 2024
This was referenced Jun 24, 2024
ematipico
approved these changes
Jun 24, 2024
CodSpeed Performance ReportMerging #3272 will improve performances by 6.73%Comparing Summary
Benchmarks breakdown
|
Sec-ant
reviewed
Jun 24, 2024
dyc3
force-pushed
the
06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
branch
from
June 24, 2024 12:13
adf5158
to
12c6730
Compare
Sec-ant
reviewed
Jun 24, 2024
dyc3
force-pushed
the
06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
branch
from
June 24, 2024 13:09
12c6730
to
5d1aab5
Compare
Sec-ant
reviewed
Jun 24, 2024
…arserSettings` to `Option`
dyc3
force-pushed
the
06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
branch
from
June 24, 2024 18:44
5d1aab5
to
a2574da
Compare
Sec-ant
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix! Could you also remove JsonParserOptions
from the PR title?
dyc3
changed the title
refactor(parse/json): change fields in
refactor(parse/json): change fields in Jun 25, 2024
JsonParserOptions
and JsonParserSettings
to Option
JsonParserSettings
to Option
Done |
dyc3
deleted the
06-23-refactor_parse_json_change_fields_in_jsonparseroptions_and_jsonparsersettings_to_option_
branch
June 26, 2024 13:20
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Changelog
Area: changelog
A-Parser
Area: parser
A-Project
Area: project
L-JSON
Language: JSON and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the JSON parser options to use
Option<bool>
for better semantics when dealing with default values and fallbacks.as discussed here: #3260 (comment)
Test Plan
CI should pass