fix(config): default value for indent_width #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
github-actions
bot
added
L-JavaScript
CodSpeed Performance ReportMerging #3096 will degrade performances by 7.14%Comparing Summary
Benchmarks breakdown
|
Sec-ant
reviewed
Jun 6, 2024
crates/biome_cli/tests/snapshots/main_commands_rage/with_formatter_configuration.snap
Outdated
Show resolved
Hide resolved
Conaclos
reviewed
Jun 6, 2024
ematipico
force-pushed
the
fix/regression-staged
branch
from
1647647 to
8ae7a3d
Compare
Conaclos
approved these changes
Jun 6, 2024
Sec-ant
reviewed
Jun 6, 2024
crates/biome_cli/tests/snapshots/main_commands_rage/with_formatter_configuration.snap
Outdated
Show resolved
Hide resolved
ematipico
force-pushed
the
fix/regression-staged
branch
from
8ae7a3d to
493f2c1
Compare
Sec-ant
approved these changes
Jun 6, 2024
ematipico
force-pushed
the
fix/regression-staged
branch
from
493f2c1 to
e8354ed
Compare
ah-yu
reviewed
Jun 7, 2024
| fn default_css() { | ||
| let css_configuration = CssFormatter::default(); | ||
|
|
||
| assert_eq!(css_configuration.indent_width, IndentWidth::default()); |
There was a problem hiding this comment.
The default value should be None; otherwise, the CSS formatter will not inherit indent_width from the global formatter settings when css.formatter.indent_width is unset.
Related: #3103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue is that we had
IndentWidth, but we weren't using it at all 😆Now we use it, and I took the chance to add a max value that we cant' exceed. It behaves the same way
LineWidthdoes.Closes #3067
Test Plan
I added a new test case