fix(lint/useSingleVarDeclarator): output valid code when declarators are on multilines #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Linter
Conaclos
changed the title
Conaclos
changed the title
ematipico
approved these changes
Dec 6, 2023
crates/biome_js_analyze/src/analyzers/style/use_single_var_declarator.rs
Outdated
Show resolved
Hide resolved
Conaclos
force-pushed
the
conaclos/lint/useSingleVarDeclarator/728
branch
3 times, most recently
from
2979f4d to
60d0b50
Compare
…are on distinct lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #728.
I also take the opportunity of adding more details in the rule description.
Test Plan
I added an anti-regression test and other tests.