fix(lint/useTemplate): correctly handle comments

CHANGELOG.md

@@ -68,6 +68,27 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
   + `${a + b}px`
    ```
 
+- Fix [rome#4109](https://github.com/rome/tools/issues/4109)
+
+  Previously, [useTemplate](https://biomejs.dev/lint/rules/useTemplate/) suggested an invalid code fix when a leading or trailing single-line comment was present:
+
+  ```diff
+    // leading comment
+  - 1 /* inner comment */ + "+" + 2 // trailing comment
+  + `${// leading comment
+  + 1 /* inner comment */}+${2 //trailing comment}` // trailing comment
+  ```
+
+  Now, the rule correctly handle this case:
+
+  ```diff
+    // leading comment
+  - 1 + "+" + 2 // trailing comment
+  + `${1}+${2}` // trailing comment
+  ```
+
+  As a sideeffect, the rule also suggests the removal of any inner comments.
+
 - Fix [#106](https://github.com/biomejs/biome/issues/106)
 
   [noUndeclaredVariables](https://biomejs.dev/lint/rules/noUndeclaredVariables/) now correctly recognizes some TypeScript types such as `Uppercase`.

crates/rome_js_analyze/src/analyzers/style/use_template.rs

@@ -214,7 +214,8 @@ fn template_chuck_from(string_literal: &JsStringLiteralExpression) -> Option<Any
 fn template_element_from(expr: AnyJsExpression) -> Option<AnyJsTemplateElement> {
     Some(AnyJsTemplateElement::from(make::js_template_element(
         JsSyntaxToken::new_detached(JsSyntaxKind::DOLLAR_CURLY, "${", [], []),
-        expr.trim()?,
+        expr.with_leading_trivia_pieces([])?
+            .with_trailing_trivia_pieces([])?,
         make::token(T!['}']),
     )))
 }

crates/rome_js_analyze/tests/specs/style/useTemplate/invalid.js

@@ -49,3 +49,8 @@ foo() + '\n';
 const x = a + ("b") + c;
 
 ("a") + (b) + ("c");
+
+//a
+/*b*/ foo /*c*/ + /*d*/ 'baz' /*e*/ + /*f*/ 1 //g
++ //h
+bar //i

crates/rome_js_analyze/tests/specs/style/useTemplate/invalid.js.snap

@@ -56,6 +56,11 @@ const x = a + ("b") + c;
 
 ("a") + (b) + ("c");
 
+//a
+/*b*/ foo /*c*/ + /*d*/ 'baz' /*e*/ + /*f*/ 1 //g
++ //h
+bar //i
+
 ```
 
 # Diagnostics
@@ -408,7 +413,7 @@ invalid.js:27:1 lint/style/useTemplate  FIXABLE  ━━━━━━━━━━
     25 25 │   foo() + '\n';
     26 26 │   
     27    │ - 1·*·/**leading*/'foo'····/**trailing·*/···················+·'bar';
-       27 │ + `${1·*·/**leading*/'foo'····/**trailing·*/}bar`;
+       27 │ + `${1·*·/**leading*/'foo'}bar`;
     28 28 │   
     29 29 │   // strings including `${`
   
@@ -641,6 +646,7 @@ invalid.js:51:1 lint/style/useTemplate  FIXABLE  ━━━━━━━━━━
   > 51 │ ("a") + (b) + ("c");
        │ ^^^^^^^^^^^^^^^^^^^
     52 │ 
+    53 │ //a
   
   i Suggested fix: Use a template literal.
   
@@ -649,6 +655,33 @@ invalid.js:51:1 lint/style/useTemplate  FIXABLE  ━━━━━━━━━━
     51    │ - ("a")·+·(b)·+·("c");
        51 │ + `a${b}c`;
     52 52 │   
+    53 53 │   //a
+  
+
+```
+
+```
+invalid.js:54:7 lint/style/useTemplate  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  ! Template literals are preferred over string concatenation.
+  
+    53 │ //a
+  > 54 │ /*b*/ foo /*c*/ + /*d*/ 'baz' /*e*/ + /*f*/ 1 //g
+       │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+  > 55 │ + //h
+  > 56 │ bar //i
+       │ ^^^
+    57 │ 
+  
+  i Suggested fix: Use a template literal.
+  
+    52 52 │   
+    53 53 │   //a
+    54    │ - /*b*/·foo·/*c*/·+·/*d*/·'baz'·/*e*/·+·/*f*/·1·//g
+    55    │ - +·//h
+    56    │ - bar·//i
+       54 │ + /*b*/·`${foo}baz${1}${bar}`·//i
+    57 55 │   
   
 
 ```

website/src/content/docs/internals/changelog.mdx

@@ -74,6 +74,27 @@ Read our [guidelines for writing a good changelog entry](https://github.com/biom
   + `${a + b}px`
    ```
 
+- Fix [rome#4109](https://github.com/rome/tools/issues/4109)
+
+  Previously, [useTemplate](https://biomejs.dev/lint/rules/useTemplate/) suggested an invalid code fix when a leading or trailing single-line comment was present:
+
+  ```diff
+    // leading comment
+  - 1 /* inner comment */ + "+" + 2 // trailing comment
+  + `${// leading comment
+  + 1 /* inner comment */}+${2 //trailing comment}` // trailing comment
+  ```
+
+  Now, the rule correctly handle this case:
+
+  ```diff
+    // leading comment
+  - 1 + "+" + 2 // trailing comment
+  + `${1}+${2}` // trailing comment
+  ```
+
+  As a sideeffect, the rule also suggests the removal of any inner comments.
+
 - Fix [#106](https://github.com/biomejs/biome/issues/106)
 
   [noUndeclaredVariables](https://biomejs.dev/lint/rules/noUndeclaredVariables/) now correctly recognizes some TypeScript types such as `Uppercase`.