Generate GHA workflow files from originals #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved original .github/workflows/*.yml files to a new dir called .github/workflows-ys/ Added a Makefile to the new directory. Running `make build` from there will generate the workflows/*.yml files from workflows-src/*.yml files using YAMLScript. Plain YAML files are valid YAMLScript, so these newly generated files should work the same. The generated files have no comments and are formatted according to ys default rules. From here forward, changes to the workflows-src files should not produce any changes to the workflow files. This allows us to progressively refactor the workflow-src files and be sure no bad side effects have happened.
ingydotnet
force-pushed
the
ys-workflows
branch
from
576a4ed to
94a619d
Compare
biojppm
force-pushed
the
ys-workflows
branch
2 times, most recently
from
9408a6d to
89c896f
Compare
ingydotnet
force-pushed
the
ys-workflows
branch
from
291fad5 to
d725d6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
- Coverage 97.28% 97.13% -0.15%
==========================================
Files 34 33 -1
Lines 11267 10473 -794
==========================================
- Hits 10961 10173 -788
+ Misses 306 300 -6 ☔ View full report in Codecov by Sentry. |
biojppm
force-pushed
the
ys-workflows
branch
5 times, most recently
from
45a7834 to
fb0b0b2
Compare
biojppm
force-pushed
the
ys-workflows
branch
2 times, most recently
from
6fda518 to
9649f5c
Compare
biojppm
force-pushed
the
ys-workflows
branch
4 times, most recently
from
4a1d725 to
3d7fdb9
Compare
|
Thanks @ingydotnet ! This enables an effective way of working around github's limited workflow syntax, and makes maintenance of the workflows a breeze. For example, that is, 185 -> 957 lines, and 7KB -> 33KB. That's a huge saving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved original .github/workflows/*.yml files to a new dir called .github/workflows-ys/
Added a Makefile to the new directory. Running
make buildfrom there will generate the workflows/.yml files from workflows-src/.yml files using YAMLScript. Plain YAML files are valid YAMLScript, so these newly generated files should work the same.The generated files have no comments and are formatted according to ys default rules.
From here forward, changes to the workflows-src files should not produce any changes to the workflow files.
This allows us to progressively refactor the workflow-src files and be sure no bad side effects have happened.