Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overzealous check in emit_as() #357

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Fix overzealous check in emit_as() #357

merged 2 commits into from
Mar 2, 2023

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Mar 1, 2023

Fixes #356

biojppm added 2 commits March 2, 2023 00:50
an id may be larger than the tree's size, eg when nodes were removed
@biojppm biojppm changed the title Fix overzealous assert in emit_as() Fix overzealous check in emit_as() Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #357 (95a4608) into master (f63d129) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files          22       22           
  Lines        8067     8072    +5     
=======================================
+ Hits         7781     7786    +5     
  Misses        286      286           
Impacted Files Coverage Δ
src/c4/yml/emit.def.hpp 92.20% <100.00%> (ø)
src/c4/yml/node.hpp 98.52% <0.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@biojppm biojppm merged commit 7c0036e into master Mar 2, 2023
@biojppm biojppm deleted the fix/356 branch March 2, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emit_yaml raises id < t.size() exception after using remove_child
1 participant