Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Tree::duplicate_children_no_rep #340

Merged
merged 6 commits into from
Dec 8, 2022

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Dec 5, 2022

don't call move with prev = NONE

Fixes #277

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #340 (7f0619b) into master (10c2fe1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   96.45%   96.45%   -0.01%     
==========================================
  Files          22       22              
  Lines        8068     8062       -6     
==========================================
- Hits         7782     7776       -6     
  Misses        286      286              
Impacted Files Coverage Δ
src/c4/yml/tree.cpp 94.94% <100.00%> (+<0.01%) ⬆️
src/c4/yml/tree.hpp 98.96% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NaN-git NaN-git force-pushed the fix-duplicate-no-rep branch 2 times, most recently from 268dddc to 67aa711 Compare December 7, 2022 01:36
@biojppm biojppm force-pushed the fix-duplicate-no-rep branch from 67aa711 to 7f0619b Compare December 7, 2022 15:10
@biojppm
Copy link
Owner

biojppm commented Dec 7, 2022

@NaN-git I've rebased on the other branch, and force-pushed. Waiting for the tests to complete before merging.

@biojppm biojppm merged commit 49411ee into biojppm:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge fails with duplicate keys
3 participants