Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] json emitter should escape control characters #298

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Aug 27, 2022

fixes #297

@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #298 (2eb72db) into master (4ee4e84) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   97.16%   97.20%   +0.03%     
==========================================
  Files          78       78              
  Lines       18009    18052      +43     
==========================================
+ Hits        17499    17547      +48     
+ Misses        510      505       -5     
Impacted Files Coverage Δ
src/c4/yml/emit.def.hpp 92.14% <100.00%> (+1.41%) ⬆️
test/test_json.cpp 98.88% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@biojppm biojppm merged commit f020b03 into master Aug 29, 2022
@biojppm biojppm deleted the fix/emitjson branch August 29, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON emitter does not escape control characters
1 participant