Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Tree::_grow_arena() should start from size and not position #290

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Aug 1, 2022

fixes #288

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #290 (ec28a2b) into master (d44a9b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          77       77           
  Lines       17124    17147   +23     
=======================================
+ Hits        16630    16653   +23     
  Misses        494      494           
Impacted Files Coverage Δ
src/c4/yml/tree.cpp 94.72% <100.00%> (ø)
src/c4/yml/tree.hpp 98.64% <100.00%> (-0.01%) ⬇️
test/test_case.cpp 87.18% <100.00%> (+0.13%) ⬆️
test/test_tree.cpp 99.89% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@biojppm biojppm changed the title [fix] re #288: add test reproducing [fix] Tree::_grow_arena() should start from size and not position Aug 1, 2022
@biojppm biojppm merged commit b420799 into master Aug 2, 2022
@biojppm biojppm deleted the fix/grow_arena branch August 2, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault on successive calls to Tree::_grow_arena()
1 participant