[fix] json emitter: ensure quoting of scalars with leading 0

re #291
biojppm · Aug 30, 2022 · b5ac42a · b5ac42a
1 parent 6a0f6bc
commit b5ac42a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/c4/yml/emit.def.hpp b/src/c4/yml/emit.def.hpp
@@ -879,7 +879,7 @@ template<class Writer>
 void Emitter<Writer>::_write_scalar_json(csubstr s, bool as_key, bool was_quoted)
 {
     // json only allows strings as keys
-    if(!as_key && !was_quoted && (s.is_number() || s == "true" || s == "null" || s == "false"))
+    if(!as_key && !was_quoted && ((s.is_number() && !s.begins_with('0')) || s == "true" || s == "null" || s == "false"))
     {
         this->Writer::_do_write(s);
     }

diff --git a/test/test_json.cpp b/test/test_json.cpp
@@ -220,6 +220,14 @@ broken_value: '0.30.2'
 )");
 }
 
+TEST(emit_json, issue291)
+{
+    Tree t = parse_in_arena("{}");
+    t["james"] = "045";
+    auto s = emitrs_json<std::string>(t);
+    EXPECT_EQ(s, "{\"james\": \"045\"}");
+}
+
 TEST(emit_json, issue292)
 {
     EXPECT_FALSE(csubstr("0.1.0").is_number());