Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to pure ECMAScript modules #67

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Change to pure ECMAScript modules #67

merged 5 commits into from
Oct 11, 2023

Conversation

Enet4
Copy link
Collaborator

@Enet4 Enet4 commented Oct 10, 2023 •
edited
Loading

Summary

  • Transition to pure ESM modules
    • Usage is practically the same when using TypeScript or with interoperability layers. When in CommonJS, use dynamic import() instead of require.
    • Set transpilation target to ES2019
  • Drop support for standalone bundling
  • Remove unneeded dev dependencies
  • Remove jsconfig.json and other obsolete files
  • Update documentation accordingly

@Enet4
Copy link
Collaborator Author

Enet4 commented Oct 10, 2023 •
edited
Loading

nyc failed to give results, probably the same issue as istanbuljs/nyc#1528.

Changing Node.js to 16 does not seem to help, so it might not be istanbuljs/nyc#1530.

@Enet4 Enet4 mentioned this pull request Oct 10, 2023
Merged
@Enet4
Transition to pure ESM modules
98c8ddf 
- always import modules with extension
- add ts-node esm loader when testing with mocha
- update documentation accordingly
@Enet4
Remove jsconfig.json
a2bcd22
@Enet4
Drop support for standalone bundling
50fd941 
- remove bundling
- remove build script
- change documentation accordingly
@Enet4
Fix .c8rc
14cb7fe 
- The new configuration requires
  included extension to be ".ts"
@Enet4
Update package lock again
9bba89b
@coveralls
Copy link

Coverage Status

coverage: 98.331% (+0.6%) from 97.684% when pulling 9bba89b on change/pure-esm into 8285169 on master.

@Enet4 Enet4 merged commit 9bf1fad into master Oct 11, 2023
4 checks passed
@Enet4 Enet4 deleted the change/pure-esm branch October 11, 2023 11:17
Enet4 added a commit that referenced this pull request Oct 27, 2023
@Enet4
Remove browserify
5727497 
- no longer needed since #67
@Enet4 Enet4 mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enet4 @coveralls